Skip to content

modified oclIinit.c#2

Open
nikoloutsa wants to merge 1 commit intoHydroBench:masterfrom
nikoloutsa:master
Open

modified oclIinit.c#2
nikoloutsa wants to merge 1 commit intoHydroBench:masterfrom
nikoloutsa:master

Conversation

@nikoloutsa
Copy link
Copy Markdown

On branch master
Changes to be committed:
(use "git reset HEAD ..." to unstage)

modified:   oclInit.c

 On branch master
 Changes to be committed:
   (use "git reset HEAD <file>..." to unstage)

	modified:   oclInit.c
@nikoloutsa
Copy link
Copy Markdown
Author

The files GetDevice.h , GetDevice.cu
do not exist inside the OpenCL implementations, so i commented out these calls.

@guillcdv
Copy link
Copy Markdown
Collaborator

guillcdv commented Apr 7, 2015

Nikos,
the actual files are getDevice.c and getDevice.h which are indeed call
from oclInit.c
The last version I committed takes this into account. You should be able
to do the builds either with MPI or without it and still use the
GetDevice function.

Commenting out the code in oclInit.c would break the MPi version
especially if you have

The GetDevice.[ch] is a leftover from the cuda version which I should
have erased. Which I will do right away.

Could you double check that the last commit I did works for you ? I
tested it at home (CPU) and at work (GPU = K40) with and without MPI.
Worked great for me.

Thanks.
Guillaume

Le 07/04/2015 15:53, Nikos Nikoloutsakos a écrit :

The files GetDevice.h , GetDevice.cu
do not exist inside the OpenCL implementations, so i commented out
these calls.


Reply to this email directly or view it on GitHub
#2 (comment).

@HydroBench
Copy link
Copy Markdown
Owner

Nikos,
BTW, I updated the README.first file.
Do the comments clarify things ?
Thanks for helping me make it crystal clear for everyone.
Cheers,
Guillaume

De : guillcdv [mailto:notifications@github.com]
Envoyé : mardi 7 avril 2015 17:16
À : HydroBench/Hydro
Objet : Re: [Hydro] modified oclIinit.c (#2)

Nikos,
the actual files are getDevice.c and getDevice.h which are indeed call
from oclInit.c
The last version I committed takes this into account. You should be able
to do the builds either with MPI or without it and still use the
GetDevice function.

Commenting out the code in oclInit.c would break the MPi version
especially if you have

The GetDevice.[ch] is a leftover from the cuda version which I should
have erased. Which I will do right away.

Could you double check that the last commit I did works for you ? I
tested it at home (CPU) and at work (GPU = K40) with and without MPI.
Worked great for me.

Thanks.
Guillaume

Le 07/04/2015 15:53, Nikos Nikoloutsakos a écrit :

The files GetDevice.h , GetDevice.cu
do not exist inside the OpenCL implementations, so i commented out
these calls.


Reply to this email directly or view it on GitHub
#2 (comment).


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-90605001.

@nikoloutsa
Copy link
Copy Markdown
Author

Thank you,
maybe you can update Makefile too, (getDevice.o getDevice.c getDevice.h)
I think thats what i was missing ...

I can compile now.
If i got a sucessfull run i will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants