perf: FIT-1329: Add caching for MST union types to avoid recreation #9298
+102
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large labeling configs create many identical union types, each requiring expensive MST type construction. This adds multi-level caching to avoid recreating identical types. Changes: - Cache unionArray() results by sorted array key - Cache oneOfTags union types in _oneOf() - Cache unionTag() enumeration types - Cache tagsTypes() frozen types - Cache allModelsTypes() result (invalidates when Registry changes) - Convert O(n) arr.find()/includes() to O(1) Set.has() lookups - Add Set-based lookups in getParentOfTypeString/getParentTagOfTypeString With 200+ tags, this dramatically reduces tree building time by avoiding redundant type construction and linear searches.
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9298 +/- ##
============================================
- Coverage 66.82% 55.88% -10.95%
============================================
Files 830 575 -255
Lines 64879 41500 -23379
Branches 10971 11473 +502
============================================
- Hits 43355 23192 -20163
+ Misses 21520 18304 -3216
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
unionArray(),unionTag(), andtagsTypes()create new MST union types on every call. During tree building with large configs, identical unions are recreated thousands of times.Solution
Add module-level caching:
unionArray()results by array contentsunionTag()results by tag typetagsTypes()resultsgetParentOfTypeString()andgetParentTagOfTypeString()to use Set lookupsFiles Changed
web/libs/editor/src/core/Types.jsJira
FIT-1329
Made with Cursor