Skip to content

docs: FIT-1301: Document memory leak feature flags investigation#9267

Open
bmartel wants to merge 1 commit intodevelopfrom
fb-fit-1301
Open

docs: FIT-1301: Document memory leak feature flags investigation#9267
bmartel wants to merge 1 commit intodevelopfrom
fb-fit-1301

Conversation

@bmartel
Copy link
Contributor

@bmartel bmartel commented Jan 26, 2026

Problem

FF_LSDV_4620_3_ML is explicitly disabled in the codebase without clear documentation of why. This flag controls important memory cleanup behavior in the V17 destroy path.

Solution

Create MEMORY_INVESTIGATION.md documenting:

  • What the flag controls (clearRenderedApp, selfDestroy, reference nulling)
  • Why it is disabled (LSE/LSO React build differences)
  • What cleanup is skipped when disabled
  • Recommended mitigation strategies that work without the flag
  • Testing recommendations for re-enabling

Files Changed

  • web/libs/editor/src/MEMORY_INVESTIGATION.md (new file)

Document findings from investigating FF_LSDV_4620_3_ML and FF_DEV_3391
feature flags:

- FF_LSDV_4620_3_ML is explicitly disabled due to LSE/LSO React build
  differences, causing memory leaks in V17 destroy path
- FF_DEV_3391 controls per-annotation config trees for View All mode
- Includes mitigation strategies that work without enabling flags
- Provides testing recommendations for re-enabling the flag
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.77%. Comparing base (609d271) to head (de1e9ae).
⚠️ Report is 8 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (609d271) and HEAD (de1e9ae). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (609d271) HEAD (de1e9ae)
pytests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9267      +/-   ##
===========================================
- Coverage    66.82%   57.77%   -9.05%     
===========================================
  Files          830      561     -269     
  Lines        64879    40547   -24332     
  Branches     10971    11008      +37     
===========================================
- Hits         43355    23428   -19927     
+ Misses       21520    17115    -4405     
  Partials         4        4              
Flag Coverage Δ
lsf-e2e 51.92% <ø> (-0.07%) ⬇️
lsf-integration 48.21% <ø> (-0.06%) ⬇️
lsf-unit 8.86% <ø> (-0.02%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify
Copy link

netlify bot commented Jan 26, 2026

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit de1e9ae
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/6977b0321db95d0008947a1a

@netlify
Copy link

netlify bot commented Jan 26, 2026

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit de1e9ae
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/6977b0327cc9ec0008333c65

@netlify
Copy link

netlify bot commented Jan 26, 2026

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit de1e9ae
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/6977b032a0b356000754c87d
😎 Deploy Preview https://deploy-preview-9267--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 26, 2026

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit de1e9ae
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/6977b0327c588e00086b418e
😎 Deploy Preview https://deploy-preview-9267--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant