perf: FIT-1300: Memoize sorted entities and capabilities in AnnotationsCarousel#9266
Open
perf: FIT-1300: Memoize sorted entities and capabilities in AnnotationsCarousel#9266
Conversation
Add useMemo for: - sortedEntities: avoid re-sorting array on every render - capabilities: avoid creating new object on every render This reduces unnecessary work during re-renders when parent components update. The OutlinerTree already has virtualization for regions list, which is the main bottleneck for large datasets.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #9266 +/- ##
===========================================
- Coverage 66.82% 57.81% -9.02%
===========================================
Files 830 561 -269
Lines 64879 40550 -24329
Branches 10971 11008 +37
===========================================
- Hits 43355 23443 -19912
+ Misses 21520 17103 -4417
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sortAnnotations()is called on every render, re-sorting the array unnecessarily. The capabilities object is also recreated on every render, causing child components to receive new props.Solution
Add
useMemofor:sortedEntitiesto avoid re-sorting on every rendercapabilitiesobject to maintain referential equalityFiles Changed
web/libs/editor/src/components/AnnotationsCarousel/AnnotationsCarousel.tsx