perf: FIT-1298: Cache Area union types by tag type in dispatcher#9264
Open
perf: FIT-1298: Cache Area union types by tag type in dispatcher#9264
Conversation
The Area dispatcher was creating a new types.union() for every area deserialization, even when the same tag type would produce the same union. For annotations with many regions, this created thousands of duplicate union types. Added a cache keyed by tag type so that the union is only created once per tag type and reused for subsequent areas of the same type.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #9264 +/- ##
===========================================
- Coverage 66.82% 57.13% -9.69%
===========================================
Files 830 561 -269
Lines 64879 40553 -24326
Branches 10971 11009 +38
===========================================
- Hits 43355 23170 -20185
+ Misses 21520 17379 -4141
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Area dispatcher creates a new
types.union()for every region deserialization, even when the same tag type would produce the same union. For annotations with many regions, this creates thousands of duplicate union types.Solution
Add a cache keyed by tag type so that the union is only created once per tag type and reused for subsequent areas of the same type.
Files Changed
web/libs/editor/src/regions/Area.js