perf: FIT-1296: Consolidate extractNames into single tree traversal#9262
Open
perf: FIT-1296: Consolidate extractNames into single tree traversal#9262
Conversation
Previously extractNames() called traverseTree() twice - once to build the names map and once to process toName bindings. This doubles the traversal time for large configs. Changes: - Consolidate both traversals into a single pass - Collect control tags during traversal for toName processing - Use Set for objectTypes lookup (O(1) instead of O(n) includes) - Process toName bindings in a simple loop after traversal For configs with 200+ tags, this reduces traversal from 400+ node visits to 200+.
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9262 +/- ##
============================================
- Coverage 66.82% 56.69% -10.13%
============================================
Files 830 561 -269
Lines 64879 40560 -24319
Branches 10971 11011 +40
============================================
- Hits 43355 22997 -20358
+ Misses 21520 17559 -3961
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
extractNames()in Tree.tsx traverses the config tree twice - once to build the names map and once to process toName bindings. For configs with 200+ tags, this doubles the initialization time.Solution
Consolidate both traversals into a single pass:
Setfor objectTypes lookup (O(1) instead of O(n) includes)Files Changed
web/libs/editor/src/core/Tree.tsx