-
Notifications
You must be signed in to change notification settings - Fork 7
HBASE-26745 Include Balancer Cost metrics in jmx endpoint #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks! can you see about adding a test case somewhere? I think it'll be required in order ot upstream. Also, can you format your commit message like this:
In general the upstream hbase requirement is to format like this: |
fe3dcf8 to
3d6f10c
Compare
|
Validated with the additional metric attribute in the test. Running without the change produces the following test error: |
|
LGTM! Can you squash to one commit before merging? You can then cherry-pick that commit into a new branch based off |
6dd39b1 to
a9f7907
Compare
Done! One quick clarification - I should merge this PR here and then make the upstream PR? |
|
Yep! It might require an addendum after the fact if they require changes, but so far that hasn't been a huge issue. |
|
I just realized when I merged this in here it has the Merge pull request #4 from HubSpot/HBASE-26745-hubsp in the merge commit. Should i squash this merge commit into the actual work ? |
|
Also opened my first upstream pr! 🎉 |
|
Nice! We can leave the merge commit for now. Though in the future would choose "Squash and Merge" I have the upstream PR an approval but we'll have to wait for a committer to take a look |
|
@bbeaudreault Last question. Since this impacts the hmasters - should i still roll this out to all the hb2 cluster region servers with the upgrade job? |
|
probably not worth doing a full regionserver rollout for this change |
# This is the 1st commit message: Add maven and RPM building in blazar This uses our standard buildpack, but each module must get a custom .blazar.yaml to pass in required properties to the build. One can distribute that .blazar.yaml using build-scripts/copy_blazar_yaml.sh. In order to minimize the duplication, most of the customizations are consolidated in build-scripts/prepare_environment.sh. The RPM build is hooked into the standard build hbase-assembly, as a post-build step. The RPM build scripts in hbase-assembly/rpm-build handle turning the assembled tar.gz into multiple RPMs. We required some minor changes to the descriptor in hbase-assembly to account for the fact that our build processes each module independently instead of as a single reactor build. As a result, moduleSet does not work, so moduleSet usages were converted to dependencySet. # This is the commit message #2: Fixes to get HubSpot build to work - Our branch version munging script set-maven-versions can't parse the pom.xml due to unicode, remove it. - Our build adds build.json files to the jars. Allowlist those files in jar content verification. We could potentially try to upstream generic versions changes of these at some point # This is the commit message #3: Add client bundles for hbase2 (#11) * Add hubspot client bundles * add cdh5 mode and build the client bundles using cdh5 hadoop and java8 for now # This is the commit message #4: Add AggregationClient to client bundle (#12) # This is the commit message #5: Shade hadoop compat classes so they can be loaded in hadoop jobs (#13)

Enable the balancer cost metrics to be included in the
/jmxendpoint. This should be backwards compatible and has been deployed in our cdh5 fork for over a year.