HBASE-29073 StochasticLoadBalancer has NPE potential for sumMultiplier field #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2025 10:13
…Map, rather than ordinal based indexing
rmdmattingly
commented
Jan 14, 2025
Comment on lines
+421
to
+430
| float localSumMultiplier = 0; // in case sumMultiplier is not initialized | ||
| for (CostFunction c : costFunctions) { | ||
| if (!c.isNeeded()) { | ||
| LOG.trace("{} not needed", c.getClass().getSimpleName()); | ||
| continue; | ||
| } | ||
| total += c.cost() * c.getMultiplier(); | ||
| localSumMultiplier += c.getMultiplier(); | ||
| } | ||
| sumMultiplier = localSumMultiplier; |
Collaborator
Author
There was a problem hiding this comment.
This is a small change, but sumMultiplier is initialized in balanceTable, and needsBalance is both visible to the package, and could reasonably be called before balancing. We're iterating through cost functions anyway here, we might as well have a local copy of the total multiplier
rmdmattingly
force-pushed
the
HBASE-29072
branch
from
6e71102 to
7d07c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to chain PRs here. I can ship this when #135 has been shipped