Skip to content

meek: update to gitlab url#181802

Merged
chenrui333 merged 1 commit intomasterfrom
meek-update-git-url-checksum
Aug 20, 2024
Merged

meek: update to gitlab url#181802
chenrui333 merged 1 commit intomasterfrom
meek-update-git-url-checksum

Conversation

@stefanb
Copy link
Member

@stefanb stefanb commented Aug 20, 2024

Tor project migrated their git from gitolite to gitlab, see

So, instead of the source code tarball the old url https://gitweb.torproject.org/pluggable-transports/meek.git/snapshot/meek-0.38.0.tar.gz returns a redirect to a webpage with unexpected checksum.

URL remapping is defined in https://archive.torproject.org/websites/gitolite2gitlab.txt with line:
pluggable-transports/meek tpo/anti-censorship/pluggable-transports/meek

The tarball from new gitlab has a different checksum, possibly because of slightly different compression, different contained .tar filename...


Follow-up to #175310

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Tor project migrated their git from gitolite to gitlab, see
* https://blog.torproject.org/gitolite-gitlab-migration/
* https://x.com/torproject/status/1785726621972115962

So instead of the source code the old url https://gitweb.torproject.org/pluggable-transports/meek.git/snapshot/meek-0.38.0.tar.gz returns a redirect to a webpage with different checksum

URL remapping is defined in https://archive.torproject.org/websites/gitolite2gitlab.txt
with line:
pluggable-transports/meek tpo/anti-censorship/pluggable-transports/meek

Follow-up to #175310
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Aug 20, 2024
@stefanb stefanb marked this pull request as ready for review August 20, 2024 16:13
@chenrui333 chenrui333 changed the title meek (migrate to new git repository) meek: update to gitlab url Aug 20, 2024
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Aug 20, 2024
@chenrui333 chenrui333 enabled auto-merge August 20, 2024 17:06
@chenrui333 chenrui333 added this pull request to the merge queue Aug 20, 2024
Merged via the queue into master with commit 2a92cc0 Aug 20, 2024
@chenrui333 chenrui333 deleted the meek-update-git-url-checksum branch August 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue repo-location-update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants