Skip to content

golangci-lint: build with go1.23#181469

Merged
BrewTestBot merged 2 commits intoHomebrew:masterfrom
nikaro:fix/golangci-lint-go-1-23
Aug 17, 2024
Merged

golangci-lint: build with go1.23#181469
BrewTestBot merged 2 commits intoHomebrew:masterfrom
nikaro:fix/golangci-lint-go-1-23

Conversation

@nikaro
Copy link
Contributor

@nikaro nikaro commented Aug 17, 2024

Since go1.23 has been released in Homebrew and golangci-lint was build with go1.22 it cannot work anymore.

Ping #175310

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Since go1.23 has been released in Homebrew and golangci-lint was build with go1.22 it cannot work anymore.

Ping Homebrew#175310
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Aug 17, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 17, 2024
@BrewTestBot BrewTestBot enabled auto-merge August 17, 2024 11:26
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 17, 2024
Merged via the queue into Homebrew:master with commit d58ae1a Aug 17, 2024
@nikaro nikaro deleted the fix/golangci-lint-go-1-23 branch August 17, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants