Skip to content

rover: add build patch to build with rust 1.66.0 #118952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenrui333 wants to merge 2 commits into from
Closed

rover: add build patch to build with rust 1.66.0 #118952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e67d41d
rover: add build patch to build with rust 1.66.0
chenrui333 Dec 26, 2022
1194bb0
rover: fix code style
chenrui333 Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions Formula/rover.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
class Rover < Formula
desc "CLI for managing and maintaining data graphs with Apollo Studio"
homepage "https://www.apollographql.com/docs/rover/"
url "https://github.com/apollographql/rover/archive/refs/tags/v0.10.0.tar.gz"
sha256 "5132d1e1f4f5eb3c6e8b2254e7c75c638d35023992869185704e3ead2c99e2ff"
license "MIT"
head "https://github.com/apollographql/rover.git", branch: "main"

stable do
url "https://github.com/apollographql/rover/archive/refs/tags/v0.10.0.tar.gz"
sha256 "5132d1e1f4f5eb3c6e8b2254e7c75c638d35023992869185704e3ead2c99e2ff"

# Fix build for Rust 1.66.0
# Upstream commit ref, https://github.com/apollographql/rover/commit/f41e0894824663f62caf8fab6d10a6904449ec39
# remove in next release
patch :DATA
end

bottle do
rebuild 1
sha256 cellar: :any_skip_relocation, arm64_ventura: "22c6d424681c36f59cfe9587c21217ce407195a4166264033079eda86a0909a1"
Expand Down Expand Up @@ -34,3 +42,31 @@ def install
assert_match version.to_s, shell_output("#{bin}/rover --version")
end
end

__END__
diff --git a/crates/rover-client/src/operations/graph/check/types.rs b/crates/rover-client/src/operations/graph/check/types.rs
index 842db8e..9074c32 100644
--- a/crates/rover-client/src/operations/graph/check/types.rs
+++ b/crates/rover-client/src/operations/graph/check/types.rs
@@ -22,7 +22,7 @@ impl From<CheckSchemaAsyncInput> for MutationVariables {
graph_id: input.graph_ref.name,
name: input.graph_ref.variant,
input: MutationInput {
- graph_ref: graph_ref.to_string(),
+ graph_ref: Some(graph_ref.to_string()),
proposed_schema_document: Some(input.proposed_schema),
git_context: input.git_context.into(),
config: input.config.into(),
diff --git a/crates/rover-client/src/operations/subgraph/check/types.rs b/crates/rover-client/src/operations/subgraph/check/types.rs
index 6a76692..cb06d72 100644
--- a/crates/rover-client/src/operations/subgraph/check/types.rs
+++ b/crates/rover-client/src/operations/subgraph/check/types.rs
@@ -23,7 +23,7 @@ impl From<SubgraphCheckAsyncInput> for MutationVariables {
graph_id: input.graph_ref.name,
name: input.graph_ref.variant,
input: MutationInput {
- graph_ref: graph_ref.to_string(),
+ graph_ref: Some(graph_ref.to_string()),
proposed_schema: input.proposed_schema,
git_context: input.git_context.into(),
config: input.config.into(),