Skip to content

Conversation

@AlexanderSinn
Copy link
Member

This PR fixes compilation errors caused by the new ParticleTile interface in AMReX. It does not implement full-SoA particles that are now possible.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the bug Something isn't working label Apr 17, 2023
@ax3l ax3l self-requested a review April 18, 2023 02:22
@ax3l ax3l self-assigned this Apr 18, 2023
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thx!

@ax3l ax3l merged commit e81384b into Hi-PACE:development Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants