Fix: merge subscriptions from multiple #[processor] attributes#787
Merged
Fix: merge subscriptions from multiple #[processor] attributes#787
Conversation
Previously, when multiple #[processor] attributes appeared on a struct (e.g. via cfg_attr for conditional subscriptions), only the first attribute's subscribe list was honored. The macro removed all #[processor] attributes before the compiler could invoke the macro for subsequent ones, silently discarding conditional subscriptions.
Now the macro scans sibling #[processor] attributes on the struct and merges their event types into a single subscription list, enabling patterns like:
#[processor(subscribe = [KeyboardEvent])]
#[cfg_attr(feature = "_ble", processor(subscribe = [BleStatusChangeEvent]))]
struct DisplayProcessor;
Signed-off-by: Haobo Gu <[email protected]>
Binary Size Reportuse_config/nrf52832_bleDiffuse_config/nrf52840_bleDiffuse_config/nrf52840_ble_splitDiffCentral DiffPeripheral Diffuse_rust/nrf52840_ble_splitDiffCentral DiffPeripheral Diffuse_config/pi_pico_w_bleDiffuse_config/pi_pico_w_ble_splitDiffCentral DiffPeripheral Diffuse_rust/pi_pico_w_ble_splitDiffCentral DiffPeripheral Diffuse_config/rp2040Diffuse_config/rp2040_splitDiffCentral DiffPeripheral Diffuse_rust/rp2040_splitDiffCentral DiffPeripheral Diffuse_config/stm32f1Diffuse_config/stm32f4Diffuse_config/stm32h7Diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when multiple #[processor] attributes appeared on a struct (e.g. via cfg_attr for conditional subscriptions), only the first attribute's subscribe list was honored. The macro removed all #[processor] attributes before the compiler could invoke the macro for subsequent ones, silently discarding conditional subscriptions.
Now the macro scans sibling #[processor] attributes on the struct and merges their event types into a single subscription list, enabling patterns like: