Skip to content

Add Source section to dashboard job details #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
epenet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Source section to dashboard job details #2383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Hangfire.Core/Dashboard/Content/resx/Strings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/Hangfire.Core/Dashboard/Content/resx/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,4 +578,7 @@
<data name="Metrics_SQLServer_LogFilesSize" xml:space="preserve">
<value>Log File(s) Used (MB)</value>
</data>
<data name="JobDetailsPage_Source" xml:space="preserve">
<value>Source</value>
</data>
</root>
17 changes: 16 additions & 1 deletion src/Hangfire.Core/Dashboard/Pages/JobDetailsPage.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
</div>
}

var displayParameters = job.Properties.Where(x => !x.Key.StartsWith("DBG_") && x.Key != "Continuations").ToArray();
var displayParameters = job.Properties.Where(x => !x.Key.StartsWith("DBG_") && !x.Key.StartsWith("SRC_") && x.Key != "Continuations").ToArray();

if (displayParameters.Length > 0)
{
Expand Down Expand Up @@ -190,6 +190,21 @@
}
}

var srcParameters = job.Properties.Where(x => x.Key.StartsWith("SRC_")).ToArray();
if (job.Job != null && srcParameters.Length > 0)
{
<h3 id="job-details-source">@Strings.JobDetailsPage_Source</h3>
<table class="table table-condensed job-snippet-properties" aria-describedby="job-details-source">
@foreach (var parameter in srcParameters)
{
<tr>
<td class="width-20 word-break">@parameter.Key.Substring(4)</td>
<td><pre><code>@parameter.Value</code></pre></td>
</tr>
}
</table>
}

<h3>
@if (job.History.Count > 1)
{
Expand Down
Loading