Skip to content

[Dashboard] Adding DefaultRecordsPerPage on DashboardOptions#1657

Closed
PaulARoy wants to merge 6 commits intoHangfireIO:masterfrom
PaulARoy:default-number-rows
Closed

[Dashboard] Adding DefaultRecordsPerPage on DashboardOptions#1657
PaulARoy wants to merge 6 commits intoHangfireIO:masterfrom
PaulARoy:default-number-rows

Conversation

@PaulARoy
Copy link
Contributor

This derives from the awesome work of @JesseKlaass on this PR: #937

It focuses only on parametrized default number of records per page with a DefaultRecordsPerPage option on DashboardOptions.

Things to consider:

  • DefaultRecordsPerPage is set to 10 by default, as existing

I am open to suggestions and improvements if you want!

@PaulARoy
Copy link
Contributor Author

CI failed for a reason unrelated to the PR (fetch of .net framework timed out)

@odinserj
Copy link
Member

Thank you again @PaulARoy, I've scheduled this PR also to Hangfire 1.7.12, since changes are small again. As a note for myself – we'll need to add @JesseKlaasse as co-author when merging this PR.

@PaulARoy
Copy link
Contributor Author

Clearly!
This is mainly his work; I merely adapted.

@odinserj
Copy link
Member

Great you decided to split the PR, it's much easier to accept the changes.

@PaulARoy
Copy link
Contributor Author

Agreed, some minor improvements were really nice to add but some breaking changes blocked them. I plan to add very soon the arguments lists too (point 2 on #937) — probably this week-end if you want to wait.

By the way thanks for your awesome library. Really a must have on all my projects (including pro).

@odinserj odinserj closed this in 8c92cf0 Apr 25, 2023
@odinserj
Copy link
Member

Hi Paul, I've just implemented this feature with you as a co-author to avoid merging all the page changes. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants