[Dashboard] Adding DefaultRecordsPerPage on DashboardOptions#1657
[Dashboard] Adding DefaultRecordsPerPage on DashboardOptions#1657PaulARoy wants to merge 6 commits intoHangfireIO:masterfrom
Conversation
|
CI failed for a reason unrelated to the PR (fetch of .net framework timed out) |
|
Thank you again @PaulARoy, I've scheduled this PR also to Hangfire 1.7.12, since changes are small again. As a note for myself – we'll need to add @JesseKlaasse as co-author when merging this PR. |
|
Clearly! |
|
Great you decided to split the PR, it's much easier to accept the changes. |
|
Agreed, some minor improvements were really nice to add but some breaking changes blocked them. I plan to add very soon the arguments lists too (point 2 on #937) — probably this week-end if you want to wait. By the way thanks for your awesome library. Really a must have on all my projects (including pro). |
Co-authored-by: JesseKlaasse
|
Hi Paul, I've just implemented this feature with you as a co-author to avoid merging all the page changes. Thank you for the PR! |
This derives from the awesome work of @JesseKlaass on this PR: #937
It focuses only on parametrized default number of records per page with a
DefaultRecordsPerPageoption on DashboardOptions.Things to consider:
I am open to suggestions and improvements if you want!