all dashboards requests will include initial query string#1651
Open
Alexei000 wants to merge 1 commit intoHangfireIO:mainfrom
Open
all dashboards requests will include initial query string#1651Alexei000 wants to merge 1 commit intoHangfireIO:mainfrom
Alexei000 wants to merge 1 commit intoHangfireIO:mainfrom
Conversation
Member
|
Hi @Alexei000, this is an interesting idea to make everything work with SPA. But I have a question related to security – do I understand everything correctly, and some other person who can see the URL and that query string may use it to access the Dashboard UI? |
Author
|
Hello, @odinserj! Indeed this is an issue, although I expect the string not to be entirely visible. This should be regarded more as a workaround until a better solution is found. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If initial query to dashboard (i.e.
/hangfire) also provides a query string, this will be used for all links and requests within the dashboard.This is useful to make the dashboard accessible based on a bearer token or similar. See this discussion.
If the query string is empty (default case), no link / url is changed.