Make CronExpression equality operators accept null without triggering nullable warnings #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 666db5c shipped in version 0.11.0, a
CronExpressioncan no longer be compared withnullusing the overloaded equality operators without a CS8625 nullable warning being produced. The following code shows the issue:This PR modifies the overloaded equality operators' arguments nullability to accept null values in order to make the previous example compile without warnings.
@odinserj: I also took the liberty to enable NRT annotation/checking in the
Directory.Build.propsof thetestsfolder (and treat all nullability-related warnings as errors) to align it with thesrcfolder's one. I tested it and as expected, without the other changes introduced by this PR, the unit tests would not compile anymore. Let me know whether you want to keep it this way or not.