Skip to content

suzu: Add manifest for Sony Xperia X#116

Merged
jbruechert merged 11 commits intoHalium:halium-7.1from
fredldotme:halium-7.1
Sep 20, 2018
Merged

suzu: Add manifest for Sony Xperia X#116
jbruechert merged 11 commits intoHalium:halium-7.1from
fredldotme:halium-7.1

Conversation

@fredldotme
Copy link
Contributor

@fredldotme fredldotme commented Sep 7, 2018

This manifest replaces and removes some default repositories:

  • Removal of Qualcomm SELinux policies
  • bionic: Support for loading binaries and libraries from /odm
  • Qualcomm display HAL: Added "(AOSP)" suffix
  • Qualcomm Dataservices: AOSP build

@jbruechert
Copy link
Member

I'll have a more carful look at your changes later, but would it be possible to pull request your changes to the repositories you forked from Halium instead of replacing the repo with a fork?

@fredldotme
Copy link
Contributor Author

fredldotme commented Sep 7, 2018

The required Android bionic is still awaiting pull approval.
Halium/android_bionic#5

The HAL driver author suffix "AOSP" is currently required for Mir to load the non-CAF graphics platform.

device-kernel-suzu => device-kernel-loire
All required changes for /odm support are now merged.
No need to diverge from other Halium implementations.
@fredldotme
Copy link
Contributor Author

We've since switched back to Halium's bionic as the necessary changes have been merged.

@jbruechert
Copy link
Member

Looks almost fine now, but can you please apply the formatting that is used in the other manifests before merging?

Apply proper formatting for xml and include halium-install repo for quickly installing resulting images.
@jbruechert
Copy link
Member

The remotes are usually written in multiple lines. Just have a look at the other manifests for inspiration :)
Also, please don't include the halium-install script into the device manifest. If you want it to be included, please create a pull request at the main manifest repo. (The script is not device specific)

@fredldotme
Copy link
Contributor Author

fredldotme commented Sep 19, 2018

Reorganized a little, should be conform now.
I had to add a custom sepolicy repo with sdcard and exfat SELinux policy generation deactivated. The compile time switch wasn't working so I had to
revert the commit which introduced this behaviour.
Nothing special and only necessary as Halium distributions typically don't use Android's vold anyway.

Kind hint that, should those new repos require to be maintained under the Halium umbrella, you can count me in.

@jbruechert jbruechert merged commit f734100 into Halium:halium-7.1 Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants