Added support for configurable violation reporting (error vs warn)

.gitignore

@@ -7,4 +7,5 @@
 *.log
 *.jar
 *.class
-
+.idea
+.idea_modules

README.md

@@ -59,6 +59,17 @@ If you think some instances of a warning are false positives, you can ignore the
                                     ^
     scala> val x = math.pow(5, 1/3d) + 1/0 // linter:disable // ignores all warnings
 
+### Choosing notification level
+
+Warn (default):
+
+    scalacOptions += "-P:linter:level:warn"
+
+Error:
+
+    scalacOptions += "-P:linter:level:error"
+
+
 ### Some examples of warnings
 
 ### If checks
@@ -198,7 +209,6 @@ If you think some instances of a warning are false positives, you can ignore the
 * Add more checks
 * Add more tests, report false positives
 * Pick and choose which warnings you want (configuration)
-* Choose whether they should be warnings or errors
 * Improve testing (larger samples, generated tests, ...)
 * Drop Scala 2.9 and check out new stuff such as quasiquotes
 

src/main/scala/LinterOptions.scala

@@ -1,46 +1,67 @@
 /**
- *   Copyright 2012 Foursquare Labs, Inc.
+ * Copyright 2012 Foursquare Labs, Inc.
  *
- *   Licensed under the Apache License, Version 2.0 (the "License");
- *   you may not use this file except in compliance with the License.
- *   You may obtain a copy of the License at
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
- *       http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
  *
- *   Unless required by applicable law or agreed to in writing, software
- *   distributed under the License is distributed on an "AS IS" BASIS,
- *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *   See the License for the specific language governing permissions and
- *   limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  */
 
 package com.foursquare.lint
 
 import annotation.tailrec
 
-case class LinterOptions(disabledWarningNames: Seq[String] = Nil)
+case class LinterOptions(notificationLevel: NotificationLevel = Warn, disabledWarningNames: Seq[String] = Nil)
+
+sealed trait NotificationLevel
+
+object Warn extends NotificationLevel
+
+object Error extends NotificationLevel
 
 object LinterOptions {
   def parse(options: List[String]): Either[String, LinterOptions] = parse0(options, new LinterOptions)
 
   final val EnableOnlyArgument = "enable-only"
   final val DisableArgument = "disable"
+  final val CompilerLogLevel = "level"
   final val WarningNameDelimiter = "\\+"
   final val OptionKeyValueDelimiter = ":"
 
   private def parseWarningList(fullOption: String): Either[String, Seq[String]] = fullOption.split(OptionKeyValueDelimiter) match {
-    case Array(option, warningNames) => 
-      val (validNames, invalidNames) = warningNames.split(WarningNameDelimiter).partition(Warning.NameToWarning.contains) 
+    case Array(option, warningNames) =>
+      val (validNames, invalidNames) = warningNames.split(WarningNameDelimiter).partition(Violation.NameToWarning.contains)
       if (validNames.nonEmpty && invalidNames.isEmpty) Right(validNames)
       else Left("The '%s' option referenced invalid warnings: %s".format(option, invalidNames.mkString(", ")))
     case _ => Left("The '%s' option was not of the expected form.")
   }
-
+
+  private def parseNotificationLevel(fullOption: String): Either[String, NotificationLevel] = fullOption.split(OptionKeyValueDelimiter) match {
+    case Array(option, level) =>
+      level match {
+        case "warn" => Right(Warn)
+        case "error" => Right(Error)
+        case _ => Left(s"$fullOption is invalid. Only warn and error are supported")
+      }
+    case _ => Left(s"$fullOption was not of the expected form")
+  }
+
   @tailrec
   private def parse0(options: List[String], linterOptions: LinterOptions): Either[String, LinterOptions] = options match {
     case Nil => Right(linterOptions)
+    case option :: xs if (option.startsWith(CompilerLogLevel)) => parseNotificationLevel(option) match {
+      case Right(level) => parse0(xs, linterOptions.copy(notificationLevel = level))
+      case Left(error) => Left(error)
+    }
     case option :: xs if (option.startsWith(DisableArgument) || option.startsWith(EnableOnlyArgument)) => parseWarningList(option) match {
-      case Right(warnings) if option.startsWith(EnableOnlyArgument) => parse0(xs, linterOptions.copy(disabledWarningNames = Warning.AllNames.diff(warnings))) 
+      case Right(warnings) if option.startsWith(EnableOnlyArgument) => parse0(xs, linterOptions.copy(disabledWarningNames = Violation.AllNames.diff(warnings)))
       case Right(warnings) => parse0(xs, linterOptions.copy(disabledWarningNames = warnings))
       case Left(errorMessage) => Left(errorMessage)
     }