fix: correct RAM overhead calculation and remove redundant assignment#444
Open
Devqo wants to merge 1 commit into
Open
fix: correct RAM overhead calculation and remove redundant assignment#444Devqo wants to merge 1 commit into
Devqo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HordeWorkerProcessManager.__init__contained two issues in the initialization ofself.target_ram_overhead_bytes:9(bytes) instead of the intendedtarget_ram_overhead_bytes(9 GB by default), introduced as a regression in31d86e6aThis fix preserves the user-configured limit while ensuring it never exceeds 50% of total RAM.
Notes:
target_ram_bytes_used(the property consuming this value) currently has no callers, so this is a non-breaking cleanup. The fix prevents incorrect near-zero headroom if memory enforcement is wired up in future.psutilunrelated to this change.