Optimized MoE on Gaudi #159
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gyou2021 <[email protected]>
gyou2021
requested review from
afierka-intel,
kzawora-intel,
madamczyk-intel,
michalkuligowski and
tzielinski-habana
as code owners
xuechendi
reviewed
Apr 28, 2025
xuechendi
reviewed
Apr 28, 2025
xuechendi
reviewed
Apr 28, 2025
xuechendi
reviewed
Apr 28, 2025
Signed-off-by: gyou2021 <[email protected]>
xuechendi
reviewed
May 1, 2025
xuechendi
reviewed
May 1, 2025
Signed-off-by: gyou2021 <[email protected]>
Signed-off-by: gyou2021 <[email protected]>
xuechendi
reviewed
May 12, 2025
xuechendi
reviewed
May 12, 2025
xuechendi
reviewed
May 12, 2025
xuechendi
reviewed
May 12, 2025
vllm_hpu_extension/ops.py
Outdated
| current_hidden_states_static = torch.matmul( | ||
| current_state_static, self.w2_weight.transpose( | ||
| 1, 2)) * padded_weights | ||
| final_hidden_states = current_hidden_states_static.sum(dim=0) |
Contributor
There was a problem hiding this comment.
how about wrap static_moe as a function and invoke here?
Author
There was a problem hiding this comment.
The INC engineer suggested not to wrap it.
xuechendi
reviewed
May 12, 2025
xuechendi
reviewed
May 12, 2025
Signed-off-by: gyou2021 <[email protected]>
Signed-off-by: gyou2021 <[email protected]>
Signed-off-by: gyou2021 <[email protected]>
Signed-off-by: gyou2021 <[email protected]>
…; added static moe. Signed-off-by: gyou2021 <[email protected]>
xuechendi
reviewed
May 28, 2025
xuechendi
reviewed
May 28, 2025
| final_hidden_states = slice_final_hidden_states | ||
| else: | ||
| final_hidden_states += slice_final_hidden_states | ||
| else: |
Contributor
There was a problem hiding this comment.
don't use else. wrap static moe into a function and do:
if ...:
return static_MOE()
#existing code
...
Contributor
There was a problem hiding this comment.
May you switch the sequence,
do:
if ...:
return static_MOE()
existing codes
dynamic_moe()
instead of:
if ...:
dynamic_moe()
else:
return statc
Signed-off-by: gyou2021 <[email protected]>
Signed-off-by: gyou2021 <[email protected]>
xuechendi
reviewed
Jun 16, 2025
| # dynamic MoE is used since its performance is better than | ||
| # static MoE in this case. | ||
| self.dynamic_moe_min_tokens = int( | ||
| os.environ.get("VLLM_DYNAMIC_MOE_MIN_TOKENS", 256)) |
Contributor
There was a problem hiding this comment.
isn't this duplicated with 466 - 482?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=== update 05/13 ===
need refactoring current impl to work both bf16 and fp8 static moe
TODO:
Not need to move it as a new module according to the consultation with the INC engineer.