Remove cruxShopifyThemes.sql to fix lens filtering failures #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cruxShopifyThemes.sqlquery was causing lens filtering to fail for all lenses except "ALL". When specific lenses (liketop1k,wordpress, etc.) were applied, the SQL generation would produce malformed queries such as:This occurred because the query structure was incompatible with the lens injection mechanism for CrUX queries. The lens system attempts to inject WHERE clauses or JOINs, but the cruxShopifyThemes query had a structure that broke this process.
Root Cause
The lens filtering system works differently for CrUX queries:
crux_histograms.sqlfiles define JOINs to be injected after table referencesThe cruxShopifyThemes query structure was not compatible with either approach, resulting in malformed SQL generation.
Solution
Following guidance from maintainers in the issue comments:
Removing the problematic query file resolves the lens filtering failures while preserving all other CrUX query functionality. The lens system continues to work correctly for other CrUX queries like
cruxLcp.sql,cruxFcp.sql, etc.Fixes #212.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.