Translate 2022 PWA chapter for Simplified Chinese #3192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@rviscomi Could you please help to enable the CI again then I can check if the linting issues were fixed? Many thanks! 😊 |
tunetheweb
reviewed
Oct 3, 2022
tunetheweb
requested changes
Oct 3, 2022
Member
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
LGTM apart from a note about MDN links.
Member
Author
|
@tunetheweb Understood, will follow your great suggestions (linting learnings, MDN markdown links etc.,) in translations for other chapters. Many thanks! :) |
tunetheweb
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1067
@tunetheweb
PTAL.