-
-
Notifications
You must be signed in to change notification settings - Fork 200
Handle Russian and Ukrainian plurals #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @bazzadp. Yes, the same mechanism works for Ukrainian:
I will also need to check sentences for correct words endings in context. |
|
Thanks @tymosh . Added those in the last commit if you wanna double check. Also added test site here: https://20210204t112250-dot-webalmanac.uk.r.appspot.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Here's another thing: there are different word endings for "contributors" in constructions "124 contributors" and "5 of 124 contributors" in Ukrainian. Is there any way to do that?
Co-authored-by: Kate Tymoshkina <[email protected]>
Yes and have this working now. Take a look at the latest code. Can also view it here: https://20210204t153224-dot-webalmanac.uk.r.appspot.com @dtikhonov I presume this is the same in Russian? Can you review the latest code? |
tymosh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Kate Tymoshkina <[email protected]>
Fixes #1968 using plural-ru function. Note this is not available as an importable function so added code directly to our code base (checked the licence first).
Home page intro:

Methodology text:

Contributors:

@dtikhonov can you confirm I've used the right words?
It does look like we used "главах" below but Google Translate didn't come up with that at all so I guess double check that?
@tymosh does Ukrainian follow the same rules? Should we do the same for those templates?