修复 Terracotta 在 MacOS 上的兼容性问题 #4723
Merged
+51
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
已完成修复工作，需要请求社区帮助测试是否兼容 MacOS 10 以来的全部版本 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the Terracotta installation process on macOS and improves state management in the TerracottaManager. Key improvements include better error handling, safer package installation, and more robust state transitions.
- Improved macOS installer with better error handling, temp file cleanup, and exit code validation
- Enhanced exception handling for cancellation scenarios during installation
- Simplified state management by using atomic compareAndSet instead of direct setState for safer concurrent operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MacOSProvider.java | Enhanced installer to use temp directory, validate osascript availability, check exit codes, and clean up temp files |
| TerracottaManager.java | Added CancellationException handling and replaced setState with compareAndSet for thread-safe state transitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCL/src/main/java/org/jackhuang/hmcl/terracotta/provider/MacOSProvider.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@Glavo 我希望能够尽快合并该 PR 并推送稳定版本以解决大量 MacOS 用户无法正确安装陶瓦联机，无法加入由 PCL CE 创建的 Scaffolding 房间的问题。 |
Glavo
approved these changes
Nov 2, 2025
Glavo
added a commit
to Glavo/HMCL
that referenced
this pull request
Nov 2, 2025
Co-authored-by: Glavo <[email protected]> Co-authored-by: Copilot <[email protected]>
Merged
Glavo
added a commit
that referenced
this pull request
Nov 3, 2025
#4723 #4750 #4735 --------- Co-authored-by: Burning_TNT <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
仍在调查 MacOS 15 与 26 上的兼容性问题