Open
Conversation
Collaborator
|
Hi @regularfry, thanks for this contribution! One small suggestion: please target the PR to the nightly instead of . We typically merge new features to nightly first for testing before the next release. Btw, uv.lock should not be submit. Otherwise, looking good! |
Author
|
Ok, will do. I can see how the config is arranged has changed too, I'll realign to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds XMPP support. I'm offering it with no guarantees other than "it works for me, it might work for you too".
I've got it running against a self-hosted Snikket server which I'm talking to with the Conversations-based Snikket client. File transfers work (so I can show the bot a photo and it's correctly passed off to the multimodal model endpoint as
media). I haven't tested anything audio-related.You'll see that I haven't got to OMEMO encryption yet: that's definitely something I want to do but since I'm running this mainly over my local network and only remotely over a VPN, it's not something I'm overly concerned with personally.
I've not done much outside the channel itself here:
Annoyances:
But, as I said up top: it works for me.