Add group support when parsing imageseries#900
Merged
Conversation
This allows the imageseries to fall back to matching the group name
if other checks fail, and still apply the correct ROI.
It allows us to specify monolith detectors in the imageseries section
of the input file like so:
```yaml
image_series:
data:
- args:
path: imageseries
file: ff1.npz
panel: ff1
- args:
path: imageseries
file: ff2.npz
panel: ff2
format: frame-cache
```
This is part of the fixes required for HEXRD/hexrdgui#1970
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
added a commit
to HEXRD/hexrdgui
that referenced
this pull request
Feb 27, 2026
Exporting the HEDM workflow seemed to work fine when only monolith panels were used. However, using a subpanel setup (where each subpanel takes image data from a region of the main panel image) had bugs - specifically, re-using the same exported workflow.yml file on the original input files (or files like the original ones) would not work. This, along with HEXRD/hexrd#900, are required to fix the issue. Fixes: #1970 Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #900 +/- ##
==========================================
+ Coverage 69.41% 69.46% +0.05%
==========================================
Files 148 148
Lines 22590 22592 +2
==========================================
+ Hits 15680 15693 +13
+ Misses 6910 6899 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
bnmajor
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the imageseries to fall back to matching the group name if other checks fail, and still apply the correct ROI.
It allows us to specify monolith detectors in the imageseries section of the input file like so:
This is part of the fixes required for HEXRD/hexrdgui#1970