Code Quality, but I actually didn't do much #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Went in to be more thorough with code quality. I already wrote most of the things with code quality in mind, so this is not a very huge change. Added comments where I deliberately diverged from general code quality advice.
# Conflicts: # src/main/java/catbot/io/CatBotConsoleIo.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure some of my decisions are unconventional, but I thought about them and I thought they made sense.
No matter if you are a prof, TA, fellow student, or unrelated developer who knows better, you're welcome to strike up a conversation! I'm always looking to improve.
That being said, I'd rather do the wrong thing with strong reasons and learn why those reasons are wrong, than do the right thing for weak reasons. Hence I decided to diverge from the given code quality principles in some areas.
Nevertheless, I made sure to comment when the departure from "good code quality" is egregious.