fix: add user-configured allowRead paths to Landlock ruleset#8
Merged
Conversation
ApplyLandlockFromConfig was not processing cfg.Filesystem.AllowRead paths, causing them to be blocked by Landlock despite bwrap mounting them correctly as read-only. This made files like ~/.gitconfig inaccessible inside the sandbox when using DefaultDenyRead mode. Closes #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApplyLandlockFromConfigwas not processingcfg.Filesystem.AllowReadpaths, only hardcoded system/tooling paths andAllowWritepathsallowReadpath (e.g.~/.gitconfig) was blocked despite bwrap mounting it correctly as--ro-bindAllowReadprocessing mirroring the existingAllowWritepattern, with glob expansion and direct path supportCloses #6
Test plan
greywall --debugwithallowRead: ["~/.gitconfig"]anddenyWrite: ["~/.gitconfig"]in config; verify~/.gitconfigappears in Landlock rules outputgit loginside sandbox; verify noPermission deniedon.gitconfigmake testto verify no regressions