fix: macOS Seatbelt denyRead rules ineffective due to file-read* wildcard#20
Merged
fix: macOS Seatbelt denyRead rules ineffective due to file-read* wildcard#20
Conversation
…rules Seatbelt ignores wildcard denies (file-read*) when a specific allow (file-read-data) covers the same path. This made all denyRead rules on macOS completely ineffective — .env files and user-configured denyRead paths were readable despite deny rules in the profile. Fixes #18
a10a698 to
969f370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18
denyReadrules on macOS were completely ineffective,.env,.env.local, and all user-configureddenyReadpaths were readable despite deny rules in the Seatbelt profiledeny file-read*) when a specific allow (allow file-read-data) covers the same path. The deny must use the exact same operation name as the allow.deny file-read*→deny file-read-datain all read deny rulesfile-read-datafor denies.envfiles and userdenyReadpaths are actually blocked at runtimeHow i verified the Seatbelt behavior
Tested with
sandbox-execdirectly to isolate the semantics:Test plan
go test ./internal/sandbox/ -run "TestMacOS_DenyRead" -vgo test ./internal/sandbox/ -run "TestMacOS_SeatbeltBlocksEnv|TestMacOS_SeatbeltBlocksUserDenyRead" -vgreywall -d -- cat .envnow blocks reading.envmake fmt && make lint