-
Notifications
You must be signed in to change notification settings - Fork 13
feat: first-run UX with built-in agent profiles #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,869
−97
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7210667
feat: Add first-run UX with built-in agent profiles
tito 5fa9448
feat: add toolchain profiles and trim AdHocCommands to basic unix uti…
tito fbedece
feat: improve first-run UX, add --template composability, update README
tito 9307456
docs: fix README prompt example to match current UX
tito 411d86d
feat: add --auto-profile flag for non-interactive profile selection
tito a1f4797
refactor: rename --template to --profile, templates subcommand to pro…
tito c9d9457
fix: resolve lint errors (errcheck, gosec, gofumpt, unused)
tito e3837a7
feat: add macOS-specific paths to built-in profiles
tito 71cc817
fix: use cross-platform terminal detection instead of Linux-only TCGETS
tito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package agents | ||
|
|
||
| import ( | ||
| "github.com/GreyhavenHQ/greywall/internal/config" | ||
| "github.com/GreyhavenHQ/greywall/internal/profiles" | ||
| ) | ||
|
|
||
| func init() { | ||
| profiles.Register(profiles.AgentDef{ | ||
| Names: []string{"aider"}, | ||
| Overlay: func() *config.Config { | ||
| return &config.Config{ | ||
| Filesystem: config.FilesystemConfig{ | ||
| AllowRead: []string{"~/.aider*", "~/.config/aider", "~/.cache/aider", "~/.local/share/aider"}, | ||
| AllowWrite: []string{"~/.aider*", "~/.config/aider", "~/.cache/aider", "~/.local/share/aider"}, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package agents | ||
|
|
||
| import ( | ||
| "github.com/GreyhavenHQ/greywall/internal/config" | ||
| "github.com/GreyhavenHQ/greywall/internal/profiles" | ||
| ) | ||
|
|
||
| func init() { | ||
| profiles.Register(profiles.AgentDef{ | ||
| Names: []string{"amp"}, | ||
| Overlay: func() *config.Config { | ||
| return &config.Config{ | ||
| Filesystem: config.FilesystemConfig{ | ||
| AllowRead: []string{"~/.amp", "~/.config/amp", "~/.cache/amp", "~/.local/share/amp", "~/.local/state/amp", "~/.claude"}, | ||
| AllowWrite: []string{"~/.amp", "~/.config/amp", "~/.cache/amp", "~/.local/share/amp", "~/.local/state/amp"}, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package agents | ||
|
|
||
| import ( | ||
| "github.com/GreyhavenHQ/greywall/internal/config" | ||
| "github.com/GreyhavenHQ/greywall/internal/profiles" | ||
| ) | ||
|
|
||
| func init() { | ||
| profiles.Register(profiles.AgentDef{ | ||
| Names: []string{"auggie"}, | ||
| Overlay: func() *config.Config { | ||
| return &config.Config{ | ||
| Filesystem: config.FilesystemConfig{ | ||
| AllowRead: []string{"~/.augment"}, | ||
| AllowWrite: []string{"~/.augment"}, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package agents | ||
|
|
||
| import ( | ||
| "github.com/GreyhavenHQ/greywall/internal/config" | ||
| "github.com/GreyhavenHQ/greywall/internal/profiles" | ||
| ) | ||
|
|
||
| func init() { | ||
| profiles.Register(profiles.AgentDef{ | ||
| Names: []string{"claude", "claude-code"}, | ||
| Overlay: func() *config.Config { | ||
| return &config.Config{ | ||
| Filesystem: config.FilesystemConfig{ | ||
| AllowRead: []string{ | ||
| "~/.claude", | ||
| "~/.claude.json", | ||
| "~/.claude.json.*", | ||
| "~/.config/claude", | ||
| "~/.local/share/claude", | ||
| "~/.local/state/claude", | ||
| "~/.mcp.json", | ||
| }, | ||
| AllowWrite: []string{ | ||
| "~/.claude", | ||
| "~/.claude.json", | ||
| "~/.claude.lock", | ||
| "~/.cache/claude", | ||
| "~/.config/claude", | ||
| "~/.local/state/claude", | ||
| "~/.local/share/claude", | ||
| "~/.mcp.json", | ||
| }, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package agents | ||
|
|
||
| import ( | ||
| "github.com/GreyhavenHQ/greywall/internal/config" | ||
| "github.com/GreyhavenHQ/greywall/internal/profiles" | ||
| ) | ||
|
|
||
| func init() { | ||
| profiles.Register(profiles.AgentDef{ | ||
| Names: []string{"cline"}, | ||
| Overlay: func() *config.Config { | ||
| return &config.Config{ | ||
| Filesystem: config.FilesystemConfig{ | ||
| AllowRead: []string{"~/.cline", "~/.config/cline", "~/.cache/cline", "~/.local/share/cline", "~/.local/state/cline"}, | ||
| AllowWrite: []string{"~/.cline", "~/.config/cline", "~/.cache/cline", "~/.local/share/cline", "~/.local/state/cline"}, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package agents | ||
|
|
||
| import ( | ||
| "github.com/GreyhavenHQ/greywall/internal/config" | ||
| "github.com/GreyhavenHQ/greywall/internal/profiles" | ||
| ) | ||
|
|
||
| func init() { | ||
| profiles.Register(profiles.AgentDef{ | ||
| Names: []string{"codex"}, | ||
| Overlay: func() *config.Config { | ||
| return &config.Config{ | ||
| Filesystem: config.FilesystemConfig{ | ||
| AllowRead: []string{"~/.codex", "~/.cache/codex"}, | ||
| AllowWrite: []string{"~/.codex", "~/.cache/codex"}, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package agents | ||
|
|
||
| import ( | ||
| "github.com/GreyhavenHQ/greywall/internal/config" | ||
| "github.com/GreyhavenHQ/greywall/internal/profiles" | ||
| ) | ||
|
|
||
| func init() { | ||
| profiles.Register(profiles.AgentDef{ | ||
| Names: []string{"copilot"}, | ||
| Overlay: func() *config.Config { | ||
| return &config.Config{ | ||
| Filesystem: config.FilesystemConfig{ | ||
| AllowRead: []string{"~/.copilot"}, | ||
| AllowWrite: []string{"~/.copilot"}, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package agents | ||
|
|
||
| import ( | ||
| "github.com/GreyhavenHQ/greywall/internal/config" | ||
| "github.com/GreyhavenHQ/greywall/internal/profiles" | ||
| ) | ||
|
|
||
| func init() { | ||
| profiles.Register(profiles.AgentDef{ | ||
| Names: []string{"cursor", "cursor-agent"}, | ||
| Overlay: func() *config.Config { | ||
| return &config.Config{ | ||
| Filesystem: config.FilesystemConfig{ | ||
| AllowRead: []string{"~/.cursor", "~/.config/cursor", "~/.local/share/cursor-agent"}, | ||
| AllowWrite: []string{"~/.cursor", "~/.config/cursor", "~/.cache/cursor-compile-cache", "~/.local/share/cursor-agent"}, | ||
| }, | ||
| } | ||
| }, | ||
| }) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that Claude makes frequent use of the temp directory, which on osx is
/private/tmp/, without it many of the tool calls would fail. Worth adding maybe?Sidenote: Should default templates be os-specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, claude is not the /tmp, but /tmp/claude-xxx no ?
I feel showing the whole /tmp could be dangerous as many application leave some socket in it
I will do another pass for the os-specific - maybe i got them lost during internal refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elo-siema actually, i wonder if greywall could redirect the TMPDIR env to be local and deleted when done, that would prevent giving wide access. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, TMPDIR redirection sounds the cleanest, agreed
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but that xxx was unpredictable. Agreed on fishyness of sharing whole tmp