Skip to content

fix: using anonymous s3 access when ak and sk is not provided #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shuiyisong merged 2 commits into from
Dec 17, 2025
Merged

fix: using anonymous s3 access when ak and sk is not provided #7425

shuiyisong merged 2 commits into from
Dec 17, 2025

Conversation

@shuiyisong
Copy link
Contributor

@shuiyisong shuiyisong commented Dec 17, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

If ak and sk is not provided for s3, we have to set allow_anonymous and disable_ec2_metadata to disable loading credential.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@shuiyisong shuiyisong requested a review from a team as a code owner December 17, 2025 04:04
@shuiyisong shuiyisong requested a review from waynexia December 17, 2025 04:04
@github-actions github-actions bot added size/XS docs-not-required This change does not impact docs. labels Dec 17, 2025
@shuiyisong shuiyisong added this pull request to the merge queue Dec 17, 2025
@shuiyisong shuiyisong removed this pull request from the merge queue due to a manual request Dec 17, 2025
@shuiyisong shuiyisong added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 62808b8 Dec 17, 2025
45 checks passed
@shuiyisong shuiyisong deleted the fix/anonymous_s3 branch December 17, 2025 07:06
linyihai pushed a commit to linyihai/greptimedb that referenced this pull request Jan 28, 2026
@shuiyisong @linyihai
fix: using anonymous s3 access when ak and sk is not provided (Grepti…
e80c96a 
…meTeam#7425)

* chore: allow s3 anon

Signed-off-by: shuiyisong <[email protected]>

* chore: disable ec2 metadata

Signed-off-by: shuiyisong <[email protected]>

---------

Signed-off-by: shuiyisong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waynexia waynexia waynexia approved these changes

@WenyXu WenyXu WenyXu approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

@evenyag evenyag Awaiting requested review from evenyag

Assignees

No one assigned

Labels

docs-not-required This change does not impact docs. size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shuiyisong @waynexia @WenyXu