Skip to content

Conversation

@lyang24
Copy link
Collaborator

@lyang24 lyang24 commented Dec 12, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    i felt like the iter and collect into another hashset is not necessary as we can use the original in_used set
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Describe if this PR will break API or data compatibility (optional)

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@github-actions github-actions bot added size/XS docs-not-required This change does not impact docs. labels Dec 12, 2025
@lyang24 lyang24 force-pushed the remove_extra_hashset_in_gc_workers branch from c08bafd to df87a6b Compare December 12, 2025 08:05
@lyang24 lyang24 changed the title chore(mito): remove extra hashset in gc workers chore(mito): nit remove extra hashset in gc workers Dec 12, 2025
@lyang24 lyang24 marked this pull request as ready for review December 12, 2025 08:10
@waynexia
Copy link
Member

💯 Thank you @lyang24

@waynexia waynexia added this pull request to the merge queue Dec 18, 2025
Merged via the queue into GreptimeTeam:main with commit 658332f Dec 18, 2025
51 of 62 checks passed
linyihai pushed a commit to linyihai/greptimedb that referenced this pull request Jan 28, 2026
chore(mito): remove extra hashset in gc workers

Signed-off-by: lyang24 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants