chore(python): Print Python interpreter version#3118
chore(python): Print Python interpreter version#3118waynexia merged 2 commits intoGreptimeTeam:mainfrom tisonkun:print-py-version
Conversation
Signed-off-by: tison <wander4096@gmail.com>
|
@discord9 also I noticed that we have both pyo3 and rustpython for interop. What's the difference and why do we maintain two solutions? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3118 +/- ##
==========================================
- Coverage 85.71% 85.17% -0.54%
==========================================
Files 812 812
Lines 132958 133035 +77
==========================================
- Hits 113964 113318 -646
- Misses 18994 19717 +723 |
waynexia
left a comment
There was a problem hiding this comment.
Can you also add this for rustpython interpreter? At src/script/src/python/rspython/copr_impl.rs
|
@waynexia I'm thinking of this. Will take a look. May you take a look at #3118 (comment)? |
The original purpose is to support different backends. For an inappropriate example, you can think of this as PG and MySQL protocols. These two implementations also have some slight differences. Like GIL or runtime requirement. I don't think they are in conflict but a supplement to each other. |
So the idea is that RustPython can support simple scripting without extra setup, and cpython impl can use external python library |
Signed-off-by: tison <wander4096@gmail.com>
|
It seems we need one more explicit approval. @discord9 could you tick one? |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This relates to #3117 for improving user experience.
Checklist
Refer to a related PR or issue link (optional)