Skip to content

Conversation

@sunng87
Copy link
Member

@sunng87 sunng87 commented Feb 23, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

A bug in upstream opensrv-mysql cause occasional tls corrupt message error on tls handshake.

Upstream fix: databendlabs/opensrv#39

cc @SSebo

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Fixes #677

@sunng87 sunng87 marked this pull request as ready for review February 23, 2023 07:39
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1065 (695c33a) into develop (2df8143) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1065      +/-   ##
===========================================
- Coverage    85.70%   85.58%   -0.12%     
===========================================
  Files          450      450              
  Lines        65736    65828      +92     
===========================================
  Hits         56338    56338              
- Misses        9398     9490      +92     
Flag Coverage Δ
rust 85.58% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 43.77% <0.00%> (-14.34%) ⬇️
src/object-store/src/cache_policy.rs 78.00% <0.00%> (-12.55%) ⬇️
tests-integration/src/test_util.rs 79.16% <0.00%> (-9.47%) ⬇️
src/frontend/src/table/scan.rs 85.18% <0.00%> (-5.56%) ⬇️
src/common/procedure/src/store/state_store.rs 90.29% <0.00%> (-2.50%) ⬇️
src/servers/src/auth/user_provider.rs 81.81% <0.00%> (-2.28%) ⬇️
src/storage/src/engine.rs 89.61% <0.00%> (ø)
src/table/src/requests.rs 85.43% <0.00%> (ø)
src/common/procedure/src/local.rs 92.49% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sunng87 sunng87 merged commit 8f67d8c into GreptimeTeam:develop Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test mysql::mysql_server_test::test_server_require_secure_client_secure fails

3 participants