Enhanced clarity on 'verbosity'#2
Merged
justinwangx merged 2 commits intoAug 12, 2024
Merged
Conversation
Collaborator
|
this is great, thanks! I added a commit that changes the logging so that we still get loss + string output by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, great package.
Just a thought, the verbosity thing is a bit confusing. Right now, with tqdm() you don't need to output the step number (do you?). However, the printing functionality is basically the same if verbose is true or not. So I just simplified things down to go for what I think you had intended.