Add BuildService to cache classloaders#39
Merged
martinbonnin merged 1 commit intomainfrom Jun 10, 2025
Merged
Conversation
martinbonnin
force-pushed
the
build-service
branch
4 times, most recently
from
bc9e2f4 to
acbf496
Compare
martinbonnin
force-pushed
the
build-service
branch
from
acbf496 to
d967e2f
Compare
vlsi
reviewed
Jun 11, 2025
| } | ||
| } | ||
|
|
||
| override fun close() { |
Member
Author
There was a problem hiding this comment.
Doesn't hurt I guess but I would expect Gradle to serialize those calls.
There was a problem hiding this comment.
It would be nice to have it for consistency: you protect the read/write, so it makes sense to protect the close as well
Comment on lines
+30
to
+40
| val builder = StringBuilder(length) | ||
| var isCapitalized = false | ||
| forEach { | ||
| builder.append(if (!isCapitalized && it.isLetter()) { | ||
| isCapitalized = true | ||
| it.toString().uppercase() | ||
| } else { | ||
| it.toString() | ||
| }) | ||
| } | ||
| return builder.toString() |
There was a problem hiding this comment.
Have you considered replaceFirstChar { it.upppercase() }?
Member
Author
There was a problem hiding this comment.
This function comes from GraphQL-land where I wanted the underscores to be ignored: __foo --> __Foo. But you're right, in the general case, simple replaceFirstChar {} might be closer to what people would expect (and what Gradle is doing too?)
I made the change in #40. Let me know what you think.
Merged
martinbonnin
added a commit
that referenced
this pull request
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
This also splits the runtime in 2 parts: