Skip to content

Add Integration testing for new jib-gradle-plugin option configurationName #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2021
Merged

Add Integration testing for new jib-gradle-plugin option configurationName #3125

merged 3 commits into from
Mar 9, 2021

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Mar 9, 2021 •
edited
Loading

For #3034

@mpeddada1 mpeddada1 requested a review from chanseokoh March 9, 2021 18:19
@google-cla google-cla bot added the cla: yes label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021 •
edited
Loading

Codecov Report

Merging #3125 (0fdc624) into master (f884fa1) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3125      +/-   ##
============================================
+ Coverage     71.12%   71.15%   +0.02%     
- Complexity     2315     2316       +1     
============================================
  Files           278      278              
  Lines          9790     9789       -1     
  Branches        991      991              
============================================
+ Hits           6963     6965       +2     
+ Misses         2482     2478       -4     
- Partials        345      346       +1
Impacted Files Coverage Δ Complexity Δ
...ogle/cloud/tools/jib/api/JavaContainerBuilder.java 82.17% <0.00%> (-0.50%) 53.00% <0.00%> (-1.00%)
...b/plugins/common/PluginConfigurationProcessor.java 63.87% <0.00%> (ø) 65.00% <0.00%> (ø%)
...oud/tools/jib/builder/steps/PullBaseImageStep.java 62.05% <0.00%> (+0.27%) 20.00% <0.00%> (ø%)
...le/cloud/tools/jib/configuration/BuildContext.java 82.89% <0.00%> (+0.65%) 18.00% <0.00%> (ø%)
...om/google/cloud/tools/jib/gradle/JibExtension.java 84.21% <0.00%> (+1.75%) 20.00% <0.00%> (+1.00%)
.../main/java/com/google/cloud/tools/jib/api/Jib.java 18.18% <0.00%> (+9.09%) 2.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f884fa1...0fdc624. Read the comment docs.

@mpeddada1 mpeddada1 changed the title Add Integration testing for new option configurationName Add Integration testing for new jib-gradle-plugin option configurationName Mar 9, 2021
chanseokoh
chanseokoh approved these changes Mar 9, 2021
View reviewed changes
...ion-test/java/com/google/cloud/tools/jib/gradle/GradleLayerConfigurationIntegrationTest.java Outdated
// verify dependencies
List<String> dependencies = layers.get(2);
assertThat(dependencies)
.isEqualTo(ImmutableList.of("app/", "app/libs/", "app/libs/dependency2"));
Copy link
Member

@chanseokoh chanseokoh Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.containsExactly(...).inOrder()?

@mpeddada1 mpeddada1 merged commit 52d867f into master Mar 9, 2021
@mpeddada1 mpeddada1 deleted the gradle-configuration-test branch March 9, 2021 20:09
@nathanfallet nathanfallet mentioned this pull request Jul 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chanseokoh chanseokoh chanseokoh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1 @chanseokoh