Skip to content

[translate] fix: mark some tests as flaky #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmatsuo merged 3 commits into from
Apr 24, 2020
Merged

[translate] fix: mark some tests as flaky #3495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1150c6c
[translate] fix: mark some tests as flaky
Apr 24, 2020
8ca4af1
Merge branch 'master' into fix-translate
Apr 24, 2020
d309efd
Merge branch 'master' into fix-translate
Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions translate/cloud-client/beta_snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def test_translate_text(capsys):
assert 'Translated Text:' in out


@pytest.mark.flaky(max_runs=3, min_passes=1)
def test_batch_translate_text(capsys, bucket):
beta_snippets.batch_translate_text(
PROJECT_ID,
Expand Down Expand Up @@ -96,6 +97,7 @@ def test_list_languages_with_target(capsys):
assert u'Display Name: albanska' in out


@pytest.mark.flaky(max_runs=3, min_passes=1)
def test_create_glossary(capsys, unique_glossary_id):
beta_snippets.create_glossary(PROJECT_ID, unique_glossary_id)
out, _ = capsys.readouterr()
Expand Down Expand Up @@ -125,6 +127,7 @@ def test_translate_text_with_glossary(capsys, glossary):
assert 'cuenta' in out


@pytest.mark.flaky(max_runs=3, min_passes=1)
def test_delete_glossary(capsys, unique_glossary_id):
beta_snippets.create_glossary(PROJECT_ID, unique_glossary_id)
beta_snippets.delete_glossary(PROJECT_ID, unique_glossary_id)
Expand Down
1 change: 1 addition & 0 deletions translate/cloud-client/requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
flaky==3.6.1
pytest==5.3.2