Skip to content

Fix KeyError exception when project has no logs #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waprin merged 3 commits into from
Mar 2, 2016
Merged

Fix KeyError exception when project has no logs #209

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4010d5
Fix KeyError exception when project has no logs
Mar 1, 2016
bda970c
update fix for projects with no logs
danasmera Mar 2, 2016
a41a72d
Merge branch 'master' into master
danasmera Mar 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cloud_logging/api/list_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

# [START all]
import argparse
import sys

from googleapiclient import discovery
from oauth2client.client import GoogleCredentials
Expand All @@ -36,6 +37,9 @@ def list_logs(project_id, logging_service):

while request:
response = request.execute()
if len(response)==0:
Copy link
Contributor

@theacodes theacodes Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use if not response:

print "No logs found in project {0}".format(project_id)
Copy link
Contributor

@theacodes theacodes Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use print as a function.

sys.exit(1)
Copy link
Contributor

@theacodes theacodes Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer just return.

for log in response['logs']:
print(log['name'])

Expand Down