Added two samples for "OCR with PDF/TIFF as source files" #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

happyhuman merged 17 commits into GoogleCloudPlatform:master from happyhuman:master

Mar 12, 2019

Contributor

happyhuman commented Mar 7, 2019

The two new samples are for online document annotation.


          Added two samples for "OCR with PDF/TIFF as source files"

b38730b

googlebot added the cla: yes label


          Merge branch 'master' into master

77e8010

happyhuman requested review from dizcology and nnegrey

March 7, 2019 18:21

Contributor Author

happyhuman commented Mar 7, 2019

@nnegrey , @dizcology can you please review this PR?

happyhuman added 2 commits

March 7, 2019 12:06


          Merge branch 'master' into master

2782c91


          Merge branch 'master' into master

da78925

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/detect.py Outdated Show resolved Hide resolved

Contributor

nnegrey commented Mar 7, 2019

Should move these to the beta_snippets.py file

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/detect.py Outdated Show resolved Hide resolved

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/detect.py Outdated Show resolved Hide resolved

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/detect.py Outdated Show resolved Hide resolved

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/detect.py Outdated Show resolved Hide resolved

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/detect.py Outdated Show resolved Hide resolved

happyhuman and others added 5 commits

March 7, 2019 16:08


          Moved the code to beta_snippets.py

68b38f7


          Fixed the sub-parser names.

647b924


          Shortened the line that was too long.

64b35b8


          Added newline at the end of the file

1a23903


          Merge branch 'master' into master

974c148

dizcology reviewed

View reviewed changes

vision/cloud-client/detect/beta_snippets.py Outdated Show resolved Hide resolved

vision/cloud-client/detect/beta_snippets.py Outdated Show resolved Hide resolved

vision/cloud-client/detect/beta_snippets.py Show resolved Hide resolved

vision/cloud-client/detect/beta_snippets_test.py Show resolved Hide resolved

happyhuman and others added 4 commits

March 8, 2019 10:29


          Using the builtin open function instead

5932dd7


          Renamed a variable

51dbd14


          Merge branch 'master' into master

0a68deb


          Merge branch 'master' into master

f72efd3

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/beta_snippets.py Show resolved Hide resolved

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/beta_snippets.py Show resolved Hide resolved

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/beta_snippets.py Outdated Show resolved Hide resolved

happyhuman added 2 commits

March 8, 2019 13:33


          Fixed the wrong arg parameter

d181e56


          Added extra comment lines

4d77f8e

Contributor

nnegrey commented Mar 11, 2019

Oh should probably re-run the README generator


          Regenerated README.rst

8f16928

nnegrey reviewed

View reviewed changes

vision/cloud-client/detect/beta_snippets_test.py Outdated Show resolved Hide resolved


          Added specific strings to be unit-tested

24c9112

nnegrey approved these changes

View reviewed changes

happyhuman merged commit c2d8a9e into GoogleCloudPlatform:master

Contributor

beccasaurus commented Mar 14, 2019

@happyhuman is there going to be a follow-up PR which demonstrates async_batch_annotate_images?

@d-torres noticed that these 2 samples demonstrate calling the new synchronous version of annotating files/documents: batch_annotate_files.

vision_fulltext_detection_pdf_beta
vision_fulltext_detection_pdf_gcs_beta

The V1 Cloud Vision API currently provides:

rpc BatchAnnotateImages which is a synchronous method for analyzing images using Cloud Vision, e.g. PNG/JPG
AsyncBatchAnnotateFiles which is an asynchronous (Long-Running Operation) method for analyzing files/documents using Cloud Vision, e.g. PDF/TIFF

The v1p4beta API provides these methods:

Images
- BatchAnnotateImages ~ already exists
- New! ✅ AsyncBatchAnnotateImages ~ long-running requests for big batches of images! 🎉
Files/Documents
- New! ✅ BatchAnnotateFiles ~ synchronous requests for small batches of docs/files! 🎉
- AsyncBatchAnnotateFiles ~ already exists

This PR demonstrates how to use the new synchronous API for files/docs, but it doesn't demonstrate the new long-running operation for large batches of images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels