Skip to content

Update memcached sample #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelawyu merged 4 commits into from
May 23, 2018
Merged

Update memcached sample #619

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34efc25
Update app.standard.yaml
michaelawyu May 12, 2018
885d875
Update app.js
michaelawyu May 12, 2018
dd80dcd
Update app.flexible.yaml
michaelawyu May 12, 2018
66f19f5
Merge branch 'master' into michaelawyu-patch-3
May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions appengine/memcached/app.flexible.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ env: flex
# anyone access to your memcached service. Do not add this file to your source
# control.
env_variables:
# If you are using the App Engine Memcache service (currently in alpha),
# uncomment this section and comment out the other Memcache variables.
# USE_GAE_MEMCACHE: 1
MEMCACHE_URL: your-memcache-url
# If you are using a Memcached server with SASL authentiation enabled,
# fill in these values with your username and password.
Expand Down
6 changes: 1 addition & 5 deletions appengine/memcached/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,7 @@ const app = express();

// [START client]
// Environment variables are defined in app.yaml.
let MEMCACHE_URL = process.env.MEMCACHE_URL || '127.0.0.1:11211';

if (process.env.USE_GAE_MEMCACHE) {
MEMCACHE_URL = `${process.env.GAE_MEMCACHE_HOST}:${process.env.GAE_MEMCACHE_PORT}`;
}
let MEMCACHE_URL = process.env.MEMCACHE_URL;
Copy link
Contributor

@ace-n ace-n May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. Is MEMCACHE_URL guaranteed to be defined? (Both on GAE, and in our tutorials)
  2. If not, is there ever a situation where 127.0.0.1:11211 makes sense as a default MEMCACHE_URL value?

Copy link
Contributor Author

@michaelawyu michaelawyu May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node-on-standard doesn't have built-in memcached service anymore :( 127.0.0.1:11211 is no longer available. In our tutorials there is a clear instruction suggesting users to deploy a free memcached instance provided by RedisLab.


const mc = memjs.Client.create(MEMCACHE_URL);
// [END client]
Expand Down
5 changes: 0 additions & 5 deletions appengine/memcached/app.standard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ runtime: nodejs8
# anyone access to your memcached service. Do not add this file to your source
# control.
env_variables:
# If you are using the App Engine Memcache service,
# uncomment this section and comment out the other Memcache variables.
#USE_GAE_MEMCACHE: 1
#GAE_MEMCACHE_HOST: 35.190.255.1
#GAE_MEMCACHE_PORT: 11211
MEMCACHE_URL: your-memcache-url
# If you are using a Memcached server with SASL authentiation enabled,
# fill in these values with your username and password.
Expand Down