Skip to content

fix the params sent across to the ga endpoint. #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oluomoniyi wants to merge 4 commits into from
Closed

fix the params sent across to the ga endpoint. #582

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95992b8
fix the params sent across to the ga endpoint.
oluomoniyi Mar 27, 2018
642b716
add semicolon
oluomoniyi Mar 27, 2018
cb0e1e2
removed silly semi colon!
oluomoniyi Mar 27, 2018
e97da6a
Updated to Object.assign for legacy Node
oluomoniyi Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine/analytics/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function trackEvent (category, action, label, value, cb) {
};

return got.post('http://www.google-analytics.com/collect', {
form: data
...data
Copy link
Member

@jmdobry jmdobry Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This operator only works in Node v8.6+, but we strive to make sure our samples work with the oldest LTS version of Node, which until the end of April is Node v4. Can you update your PR to be Node v4 compatible?

Copy link
Contributor Author

@oluomoniyi oluomoniyi Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jmdobry,

Makes sense, updated to use Object.assign instead.

});
}

Expand Down