Skip to content

Updated readWriteTransaction to fix bug #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ace-n merged 2 commits into from
Feb 23, 2017
Merged

Updated readWriteTransaction to fix bug #317

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d6d015
Updated readWriteTransaction to fix bug
ryanmats Feb 22, 2017
ffb0694
Moved 300000 to minimumAmountToTransfer constant
ryanmats Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spanner/transaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ function readWriteTransaction (instanceId, databaseId) {
console.log(`The second album's marketing budget: ${secondBudget}`);

// Makes sure the second album's budget is sufficient
if (secondBudget < transferAmount) {
throw new Error(`The second album's budget (${secondBudget}) is less than the transfer amount (${transferAmount}).`);
if (secondBudget < 300000) {
throw new Error(`The second album's budget (${secondBudget}) is less than the minimum required amount of $300,000.`);
Copy link
Contributor

@ace-n ace-n Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we make the 300000 a constant, and put its declaration next to transferAmount?

(I prefer having constants defined in one place if possible rather than repeating literal values.)

Copy link
Contributor Author

@ryanmats ryanmats Feb 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
}),

Expand Down