Skip to content

chore(functions/ocr): Remove unused region tags + add clarifying comment #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 5 commits into from
Oct 26, 2020
Merged

chore(functions/ocr): Remove unused region tags + add clarifying comment #2013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b32d5cd
chore(functions/ocr): Remove unused region tags + add clarifying comment
Oct 21, 2020
92544c0
Merge branch 'master' into ace-n-patch-1
Oct 22, 2020
fc21c9e
Merge branch 'master' into ace-n-patch-1
fhinkel Oct 26, 2020
01847f4
Delete unused region tags from tests
Oct 26, 2020
b8da6ad
Merge branch 'master' into ace-n-patch-1
gcf-merge-on-green[bot] Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions functions/ocr/app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ const translate = new Translate();

// [END functions_ocr_setup]

// [START functions_ocr_publish]
/**
* Publishes the result to the given pubsub topic and returns a Promise.
*
Expand All @@ -45,7 +44,6 @@ const publishResult = async (topicName, data) => {
const [topic] = await pubsub.topic(topicName).get({autoCreate: true});
topic.publish(dataBuffer);
};
// [END functions_ocr_publish]

// [START functions_ocr_detect]
/**
Expand Down Expand Up @@ -83,14 +81,16 @@ const detectText = async (bucketName, filename) => {
lang: lang,
};

// Helper function that publishes translation result to a Pub/Sub topic
// For more information on publishing Pub/Sub messages, see this page:
// https://cloud.google.com/pubsub/docs/publisher
return publishResult(topicName, messageData);
});

return Promise.all(tasks);
};
// [END functions_ocr_detect]

// [START functions_ocr_rename]
/**
* Appends a .txt suffix to the image name.
*
Expand All @@ -101,7 +101,6 @@ const detectText = async (bucketName, filename) => {
const renameImageForSave = (filename, lang) => {
return `${filename}_to_${lang}.txt`;
};
// [END functions_ocr_rename]

// [START functions_ocr_process]
/**
Expand Down
6 changes: 3 additions & 3 deletions functions/ocr/app/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ describe('processImage', () => {
});
});

describe('functions_ocr_process functions_ocr_detect functions_ocr_publish', () => {
describe('functions_ocr_process functions_ocr_detect', () => {
it('processImage detects text', async () => {
const data = {
bucket: bucketName,
Expand Down Expand Up @@ -96,7 +96,7 @@ describe('translateText', () => {
});
});

describe('functions_ocr_translate functions_ocr_publish', () => {
describe('functions_ocr_translate', () => {
it('translateText translates and publishes text', async () => {
const data = {
data: Buffer.from(
Expand Down Expand Up @@ -131,7 +131,7 @@ describe('saveResult', () => {
});
});

describe('functions_ocr_save functions_ocr_rename', () => {
describe('functions_ocr_save', () => {
it('saveResult translates and publishes text', async () => {
const data = {
data: Buffer.from(JSON.stringify({text, filename, lang})).toString(
Expand Down