-
Notifications
You must be signed in to change notification settings - Fork 2k
Data Catalog: add delete fileset Entry sample #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Catalog: add delete fileset Entry sample #1569
Conversation
|
This change depends on googleapis/nodejs-datacatalog#74 to pass the system tests. |
JustinBeckwith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fhinkel is there a reason we'd put this here and not googleapis/nodejs-datacatalog?
Hi, @JustinBeckwith and @fhinkel,
Please let me know your thoughts. Kind regards, |
JustinBeckwith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with this, but please let @fhinkel have a look
JustinBeckwith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with this, but please let @fhinkel have a looksy
|
Sounds good to me! |
Fileset operations were added to Data Catalog's API and the client library now supports them. Samples are required to update the official docs.