Add http_config to Developer Connect Connection by ihnarayanan · Pull Request #15843 · GoogleCloudPlatform/magic-modules

ihnarayanan · 2025-12-01T21:54:56Z

fixes hashicorp/terraform-provider-google#25352

developerconnect: added `http_config` field to `google_developer_connect_connection` resource

modular-magician · 2025-12-01T22:10:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 666 insertions(+))
google-beta provider: Diff ( 5 files changed, 666 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 153 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  http_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
}

modular-magician · 2025-12-01T22:14:34Z

Tests analytics

Total tests: 37
Passed tests: 31
Skipped tests: 2
Affected tests: 4

Click here to see the affected service packages

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-12-01T22:14:53Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBasicConfigUpdate [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBearerConfigUpdate [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpConnBasicExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpConnBearerExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-12-01T22:15:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 666 insertions(+))
google-beta provider: Diff ( 5 files changed, 666 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 153 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  http_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
}

modular-magician · 2025-12-01T22:18:55Z

Tests analytics

Total tests: 37
Passed tests: 31
Skipped tests: 2
Affected tests: 4

Click here to see the affected service packages

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-12-01T22:19:12Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBasicConfigUpdate [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBearerConfigUpdate [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpConnBasicExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpConnBearerExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-12-02T21:23:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 716 insertions(+))
google-beta provider: Diff ( 5 files changed, 716 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 153 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

modular-magician · 2025-12-02T21:27:49Z

Tests analytics

Total tests: 38
Passed tests: 31
Skipped tests: 2
Affected tests: 5

Click here to see the affected service packages

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-12-02T21:28:08Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_HttpConfigPrivConnection [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBasicConfigUpdate [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBearerConfigUpdate [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpConnBasicExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpConnBearerExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-02-23T16:27:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 716 insertions(+))
google-beta provider: Diff ( 5 files changed, 716 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 507 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

modular-magician · 2026-02-23T16:33:23Z

Tests analytics

Total tests: 39
Passed tests: 31
Skipped tests: 3
Affected tests: 5

Click here to see the affected service packages

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-02-23T16:34:46Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_HttpConfigPrivConnection [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBearerConfigUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpConnBasicExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionHttpConnBearerExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBasicConfigUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-02-23T18:46:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 716 insertions(+))
google-beta provider: Diff ( 5 files changed, 716 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 507 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

modular-magician · 2026-02-23T18:48:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 716 insertions(+))
google-beta provider: Diff ( 5 files changed, 716 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 507 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

modular-magician · 2026-02-23T18:48:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 716 insertions(+))
google-beta provider: Diff ( 5 files changed, 716 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 507 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

modular-magician · 2026-02-23T18:51:58Z

Tests analytics

Total tests: 39
Passed tests: 35
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-02-23T18:53:14Z

Tests analytics

Total tests: 39
Passed tests: 35
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-02-23T18:53:25Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBasicConfigUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-02-23T18:54:35Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionHttpBasicConfigUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-02-23T18:55:27Z

Tests analytics

Total tests: 39
Passed tests: 36
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

triggering test cases

modular-magician · 2026-02-23T23:05:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 716 insertions(+))
google-beta provider: Diff ( 5 files changed, 716 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 507 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

modular-magician · 2026-02-23T23:12:47Z

Tests analytics

Total tests: 39
Passed tests: 36
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

Remove unnecessary newline

modular-magician · 2026-02-23T23:41:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 716 insertions(+))
google-beta provider: Diff ( 5 files changed, 716 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 507 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 227 insertions(+))

github-actions · 2026-02-23T23:44:57Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-02-23T23:47:30Z

Tests analytics

Total tests: 39
Passed tests: 36
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

ihnarayanan · 2026-02-23T23:50:36Z

@melinath Do you know why terraform-google-conversion-test-integration is failing? If you click the link, all the test cases pass.

melinath · 2026-02-24T23:43:24Z

The TGC integration tests are too long so they get truncated; you can click "view raw" to see the full output. However, the error in this case seems to be unrelated to your PR:

TestAccNetworkSecuritySecurityProfile_networkSecuritySecurityProfileBrokerExample_step1: missing fields in resource google_network_security_security_profile.default after cai2hcl conversion:
"tgc-test-integration": [custom_mirroring_profile.mirroring_deployment_groups]

It looks like this field was just added recently (hashicorp/terraform-provider-google#26137) so maybe it was just a timing problem. We should be good to just ignore that failure.

melinath · 2026-02-24T23:53:02Z

removed (ga) from the release note since this is being added to both google and google-beta.

melinath

Seems straightforward; has tests. LGTM.

melinath · 2026-02-25T00:00:35Z

mmv1/products/developerconnect/Connection.yaml

+    primary_resource_id: 'my-connection'
+    primary_resource_name: 'fmt.Sprintf("tf-test-connection%s", context["random_suffix"])'
+    vars:
+      connection_name: 'tf-test-connection'


This is a little odd because it results in tests using names like tf-test-tf-test-connection and docs using names like tf-test-connection, but it's consistent with the other examples here so... not blocking on it.

…15843)

ihnarayanan added 2 commits December 1, 2025 16:40

Add http_config to Developer Connect Connection

0ce2f65

update format

e6f7ee0

modular-magician added the service/developerconnect label Dec 1, 2025

add test case for service directory and ssl cert

98d82ad

Merge branch 'GoogleCloudPlatform:main' into dc-tf-update

14223a7

ihnarayanan closed this Feb 23, 2026

ihnarayanan reopened this Feb 23, 2026

ihnarayanan added 2 commits February 23, 2026 13:35

pushing to retrigger tests

69b0879

removing change

4ec0f59

Update Connection.yaml

4eeae33

triggering test cases

Update Connection.yaml

a94679a

Remove unnecessary newline

ihnarayanan marked this pull request as ready for review February 23, 2026 23:43

github-actions bot requested a review from melinath February 23, 2026 23:44

melinath approved these changes Feb 25, 2026

View reviewed changes

melinath added this pull request to the merge queue Feb 25, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 8ae14b9 Feb 25, 2026
25 of 26 checks passed

riteshghorse pushed a commit to riteshghorse/magic-modules that referenced this pull request Feb 26, 2026

Add http_config to Developer Connect Connection (GoogleCloudPlatform#…

b4a7789

…15843)

Conversation

ihnarayanan commented Dec 1, 2025 • edited by melinath Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Dec 1, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Dec 1, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 1, 2025

Uh oh!

modular-magician commented Dec 1, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Dec 1, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 1, 2025

Uh oh!

modular-magician commented Dec 2, 2025

Diff report

Uh oh!

modular-magician commented Dec 2, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 2, 2025

Uh oh!

modular-magician commented Feb 23, 2026

Diff report

Uh oh!

modular-magician commented Feb 23, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 23, 2026

Uh oh!

modular-magician commented Feb 23, 2026

Diff report

Uh oh!

modular-magician commented Feb 23, 2026

Diff report

Uh oh!

modular-magician commented Feb 23, 2026

Diff report

Uh oh!

modular-magician commented Feb 23, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 23, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 23, 2026

Uh oh!

modular-magician commented Feb 23, 2026

Uh oh!

modular-magician commented Feb 23, 2026

Tests analytics

Uh oh!

modular-magician commented Feb 23, 2026

Diff report

Uh oh!

modular-magician commented Feb 23, 2026

Tests analytics

Uh oh!

modular-magician commented Feb 23, 2026

Diff report

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

modular-magician commented Feb 23, 2026

Tests analytics

Uh oh!

ihnarayanan commented Dec 1, 2025 •

edited by melinath

Loading

melinath commented Feb 24, 2026 •

edited

Loading