Skip to content

Conversation

@Noremac201
Copy link
Contributor

@Noremac201 Noremac201 commented Oct 31, 2025

There is no way (without involving a lot more dependencies) to get Dataproc to wait on the job to be in SUCCESS state, and TF considers RUNNING to be the job created.

With no way to wait on SUCCESS, we just simply wait 90s for the job to complete.

Release Note Template for Downstream PRs (will be copied)

Internal test fix only, no need for release notes.

@Noremac201 Noremac201 force-pushed the dpmsRaceConditionFix branch from 4a7cc69 to a14d2a8 Compare October 31, 2025 17:39
@github-actions github-actions bot requested a review from hao-nan-li October 31, 2025 17:40
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 70 insertions(+))
google-beta provider: Diff ( 2 files changed, 70 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 70 insertions(+))
google-beta provider: Diff ( 2 files changed, 70 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 36
Passed tests: 28
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages
  • dataprocmetastore

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreDatabaseIamBindingGenerated
  • TestAccDataprocMetastoreDatabaseIamMemberGenerated
  • TestAccDataprocMetastoreDatabaseIamPolicyGenerated
  • TestAccDataprocMetastoreTableIamBindingGenerated
  • TestAccDataprocMetastoreTableIamMemberGenerated
  • TestAccDataprocMetastoreTableIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocMetastoreDatabaseIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreDatabaseIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreDatabaseIamPolicyGenerated [Error message] [Debug log]
TestAccDataprocMetastoreTableIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreTableIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreTableIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 36
Passed tests: 28
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages
  • dataprocmetastore

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocMetastoreDatabaseIamBindingGenerated
  • TestAccDataprocMetastoreDatabaseIamMemberGenerated
  • TestAccDataprocMetastoreDatabaseIamPolicyGenerated
  • TestAccDataprocMetastoreTableIamBindingGenerated
  • TestAccDataprocMetastoreTableIamMemberGenerated
  • TestAccDataprocMetastoreTableIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocMetastoreDatabaseIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreDatabaseIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreDatabaseIamPolicyGenerated [Error message] [Debug log]
TestAccDataprocMetastoreTableIamBindingGenerated [Error message] [Debug log]
TestAccDataprocMetastoreTableIamMemberGenerated [Error message] [Debug log]
TestAccDataprocMetastoreTableIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

There is no way (without involving a _lot_ more dependencies) to get
Dataproc to wait on the job to be in SUCCESS state, and TF considers
RUNNING to be the job created.

With no way to wait on SUCCESS, we just simply wait 90s for the job to
complete.
@Noremac201 Noremac201 force-pushed the dpmsRaceConditionFix branch from a14d2a8 to cf05088 Compare October 31, 2025 18:16
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 88 insertions(+))
google-beta provider: Diff ( 2 files changed, 88 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 36
Passed tests: 34
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore

🟢 All tests passed!

View the build log

@hao-nan-li hao-nan-li added this pull request to the merge queue Oct 31, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 6fb2d30 Oct 31, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants