Skip to content

Conversation

@BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Nov 4, 2024

Resolves hashicorp/terraform-provider-google#20174

This is due to #12061 introducing new files that did not include the hashicorp copyright header. I also added in the autogenerate header.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@BBBmau BBBmau requested a review from roaks3 November 4, 2024 16:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 485 files changed, 8245 insertions(+))
google-beta provider: Diff ( 550 files changed, 9350 insertions(+))

@wyardley
Copy link
Contributor

wyardley commented Nov 4, 2024

Think these will probably need to be pound / hash symbol vs C / go style comments (# vs //)?

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 485 files changed, 8245 insertions(+))
google-beta provider: Diff ( 550 files changed, 9350 insertions(+))

@roaks3
Copy link
Contributor

roaks3 commented Nov 5, 2024

@BBBmau can you help me understand this a little better? Is it a hard requirement for all files to have the license header? And what about the generation type header? The generation type in particular seems a bit overkill to me considering these are only meant for housing a small amount of metadata.

@github-actions
Copy link

github-actions bot commented Nov 7, 2024

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting to hear back on whether we need this

@github-actions
Copy link

github-actions bot commented Dec 2, 2024

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions
Copy link

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions
Copy link

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions
Copy link

@BBBmau, this PR is being closed due to inactivity.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 654 files changed, 11118 insertions(+))
google-beta provider: Diff ( 711 files changed, 12087 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 654 files changed, 11118 insertions(+))
google-beta provider: Diff ( 711 files changed, 12087 insertions(+))

@malhotrasagar2212
Copy link
Collaborator

Hi @roaks3 we got confirmation from internal hashicorp's team about adding the header changes to all the meta data file. Could I get a review on this.

@roaks3
Copy link
Contributor

roaks3 commented Oct 2, 2025

Hey @malhotrasagar2212 , could you clarify from my previous comment? What is the requirement here exactly?

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 655 files changed, 11135 insertions(+))
google-beta provider: Diff ( 712 files changed, 12104 insertions(+))

@github-actions github-actions bot closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants