Skip to content

fix for #747, replaceProjectId wrong directory #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankyn merged 2 commits into from
Jul 10, 2017
+3 −3
Merged

fix for #747, replaceProjectId wrong directory #748

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2e8110
fix for #747, replaceProjectId wrong directory
mpoehler Jul 10, 2017
b2fc187
replaced single quotes with double quotes to make substitution work.
mpoehler Jul 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions appengine-java8/endpoints-v2-backend/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ endpointsServer {
hostname = "echo-api.endpoints.${projectId}.cloud.goog"
}

sourceCompatibility = 1.7 // App Engine Standard uses Java 7
targetCompatibility = 1.7 // App Engine Standard uses Java 7
sourceCompatibility = 1.8
targetCompatibility = 1.8

// this replaces the ${endpoints.project.id} in appengine-web.xml and web.xml
task replaceProjectId(type: Copy) {
from 'src/main/webapp/WEB-INF/'
include '*.xml'
into 'build/exploded-backend/WEB-INF'
into 'build/exploded-${archivesBaseName}/WEB-INF'
Copy link
Contributor

@frankyn frankyn Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use double-quotes as the single-quotes doesn't substitute ${archivesBaseName}.

expand(endpoints:[project:[id:projectId]])
filteringCharset = 'UTF-8'
}
Expand Down